Implemented a fix for #1794 (giant meta info produces invalid GDS) #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix solves two problems: * Too large meta info data * Too many meta info entries The first problem is fixed by splitting the strings that serialize the meta info. The second problem is fixed by introducing prefixed strings that indicate the attribute index within the string, not inside the PROPATTR record. The solution is backward compatible, although old versions will not read all meta info and skip entries that exceed the GDS capacity. Caveat: the produced GDS files may contain duplicate PROPATTR keys. This is not strictly illegal, but some third-party processors may drop such entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix solves two problems:
The first problem is fixed by splitting the strings that serialize the meta info.
The second problem is fixed by introducing prefixed strings that indicate the attribute index within the string, not inside the PROPATTR record.
The solution is backward compatible, although old versions will not read all meta info and skip entries that exceed the GDS capacity.
Caveat: the produced GDS files may contain duplicate PROPATTR keys. This is not strictly illegal, but some third-party processors may drop such entries.